build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31997 )
Change subject: src/arch: An upgrade of SMBIOS to latest version 3.2
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/31997/4/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/31997/4/src/arch/x86/smbios.c@569
PS4, Line 569: if ((cpuid_eax(0) < 0xb) ||
trailing whitespace
https://review.coreboot.org/#/c/31997/4/src/arch/x86/smbios.c@606
PS4, Line 606: u16 core_count = smbios_processor_core_or_thread_count(PROCESSOR_CORE_TYPE);
line over 80 characters
https://review.coreboot.org/#/c/31997/4/src/arch/x86/smbios.c@607
PS4, Line 607: u16 thread_count = smbios_processor_core_or_thread_count(PROCESSOR_THREAD_TYPE);
line over 80 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31997
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab98e063874c9738e48a387cd91341d266391156
Gerrit-Change-Number: 31997
Gerrit-PatchSet: 4
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Francois Toguo Fotso
francois.toguo.fotso@intel.corp-partner.google.com
Gerrit-Comment-Date: Thu, 21 Mar 2019 00:09:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment