Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32552 )
Change subject: mb/google/sarien: Fine tune SD card D3 cold timing
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32552/1/src/mainboard/google/sarien/variants...
File src/mainboard/google/sarien/variants/sarien/gpio.c:
https://review.coreboot.org/#/c/32552/1/src/mainboard/google/sarien/variants...
PS1, Line 244: PAD_CFG_GPO(GPP_H12, 1, DEEP),
Yes the reason we put it twice is totally for timing purpose. […]
It would still get deasserted if we put the second GPIO setup into the normal table, it would just happen later. Does the reset have to be deasserted right after the power comes up?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32552
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f1752070f24833aaaab75dea8493caf2ed7f157
Gerrit-Change-Number: 32552
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Roy Mingi Park
roy.mingi.park@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 03 May 2019 18:40:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Comment-In-Reply-To: Lijian Zhao
lijian.zhao@intel.com
Gerrit-MessageType: comment