Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46404 )
Change subject: ec/google/chromeec: Add wrappers to get/set the voltage ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46404/4/src/ec/google/chromeec/ec.h File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/46404/4/src/ec/google/chromeec/ec.h... PS4, Line 361: * @return 0 on success, -1 on error Please use CB_SUCCESS and friends.
https://review.coreboot.org/c/coreboot/+/46404/4/src/ec/google/chromeec/ec.h... PS4, Line 372: int google_chromeec_regulator_get_voltage(uint32_t index, uint32_t *voltage_mv); Why not return the voltage?