Attention is currently required from: Shelley Chen, Julius Werner, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68871 )
Change subject: mem_chip_info: Update to new format ......................................................................
Patch Set 2:
(2 comments)
File src/commonlib/bsd/include/commonlib/bsd/mem_chip_info.h:
https://review.coreboot.org/c/coreboot/+/68871/comment/093e06c2_1c7122ab PS2, Line 68: mem_chip_info should we add some version / size tags, in case if we'll want to change the structure again in the future?
for example u8 entry_size, then we can at least know how to find the next entry correctly.
https://review.coreboot.org/c/coreboot/+/68871/comment/7f265758_139695f2 PS2, Line 70: uint8_t reserved[3]; should we reserve 7 bytes, for 64-bit alignment? or make the structure declared as __attribute__((packed))?