Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39884 )
Change subject: Do not select USE_BLOBS
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39884/1/src/security/intel/stm/Kcon...
File src/security/intel/stm/Kconfig:
https://review.coreboot.org/c/coreboot/+/39884/1/src/security/intel/stm/Kcon...
PS1, Line 6: USE_BLOBS
The STM binary is in the blobs repo, does it matter? Maybe depend on it?
We usually don't depend on USE_BLOBS, it would hide most of coreboot...
making an exception here could cause some confusion, I guess?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39884
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8591862699aef02e5a4ede32655fc82c44c97555
Gerrit-Change-Number: 39884
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 03 Apr 2020 20:55:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment