Jes Klinke has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44359 )
Change subject: mainboard/google/volteer: Enable long cr50 ready pulses
......................................................................
Patch Set 15:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44359/12/src/mainboard/google/volte...
File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/44359/12/src/mainboard/google/volte...
PS12, Line 35: mainboard_update_s0ix_disable_mask
SGTM.
I have created the below CL to introduce a weak method for mainboard to override.
https://review.coreboot.org/c/coreboot/+/44914
https://review.coreboot.org/c/coreboot/+/44359/12/src/mainboard/google/volte...
PS12, Line 46: gpio_override_pm
You will have to drop this from devicetree.cb now: […]
Done
https://review.coreboot.org/c/coreboot/+/44359/12/src/mainboard/google/volte...
PS12, Line 48: cfg->gpio_pm[i] = 0
memset to 0?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idef1fffd410a345678da4b3c8aea46ac74a01470
Gerrit-Change-Number: 44359
Gerrit-PatchSet: 15
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jes Klinke
jbk@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 28 Aug 2020 20:57:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jes Klinke
jbk@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment