Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38171 )
Change subject: drivers/spi/flashconsole: Fix shadowing local variable
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/38171/4/src/drivers/spi/flashconsol...
File src/drivers/spi/flashconsole.c:
https://review.coreboot.org/c/coreboot/+/38171/4/src/drivers/spi/flashconsol...
PS4, Line 35: l_offset
I would suggest `tmp_offset` instead
https://review.coreboot.org/c/coreboot/+/38171/4/src/drivers/spi/flashconsol...
PS4, Line 124: offset = offset + len;
offset += len;
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38171
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I246ebdcfd3b973e6a4aa3c15fc5f32497dcf8398
Gerrit-Change-Number: 38171
Gerrit-PatchSet: 4
Gerrit-Owner: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 04 Jan 2020 14:18:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment