[coreboot-gerrit] Change in ...coreboot[master]: security/vboot: Add measured boot mode

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29547 )

Change subject: security/vboot: Add measured boot mode
......................................................................

Patch Set 51:

(4 comments)

Still missing documentation.
It would be easier to understand if Documentation would hold:
* What is measured
* When it's measured
* Which PCR is extendend
* Which (weak) functions are invoked
* What needs to be called prior to measuring

https://review.coreboot.org/#/c/29547/51/src/lib/cbfs.c 
File src/lib/cbfs.c:

https://review.coreboot.org/#/c/29547/51/src/lib/cbfs.c@38 
PS51, Line 38: 
vboot_measure_region_hook exists in two files and is marked as weak.

https://review.coreboot.org/#/c/29547/51/src/lib/cbfs.c@70 
PS51, Line 70: 	vboot_measure_region_hook(&rdev, name, *type);
possible null pointer dereference
check if ret is not an error ?

https://review.coreboot.org/#/c/29547/51/src/lib/fmap.c 
File src/lib/fmap.c:

https://review.coreboot.org/#/c/29547/51/src/lib/fmap.c@88 
PS51, Line 88: 	vboot_measure_region_hook(area, name, 0);
check if ret is not an error ?

https://review.coreboot.org/#/c/29547/51/src/lib/fmap.c@102 
PS51, Line 102: e
check if ret is not an error ?