Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35726 )
Change subject: drivers/aspeed/common: Add support for high resolution framebuffer
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35726/4/src/drivers/aspeed/common/K...
File src/drivers/aspeed/common/Kconfig:
https://review.coreboot.org/c/coreboot/+/35726/4/src/drivers/aspeed/common/K...
PS4, Line 3: select HAVE_LINEAR_FRAMEBUFFER
: select HAVE_VGA_TEXT_FRAMEBUFFER
MAINBOARD_DO_NATIVE_VGA_INIT depends on MAINBOARD_HAS_NATIVE_VGA_INIT, so every mainboard having a A […]
ok, just ignore my comment and add what Nico said, as discussed on IRC
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35726
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7803566b64158405efc04a39f80a0ec98b44e646
Gerrit-Change-Number: 35726
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Christian Walter
christian.walter@9elements.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 31 Oct 2019 17:12:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment