[coreboot-gerrit] Change in ...coreboot[master]: google/kukui: Raising the CPU frequency

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32466 )

Change subject: google/kukui: Raising the CPU frequency
......................................................................

Patch Set 3:

Please add explicit measurements if you want to guarantee a certain minimum settle time. You could do something like this:

struct stopwatch voltage_settled;

void function_that_increases_voltage()
 {
   ...voltage increase...
   stopwatch_init_usecs_expire(&voltage_settled, 200);
 }

void mt6358_init()
 {
   ...other stuff...
   while (!stopwatch_expired(&voltage_settled))
     /* wait for voltages to settle */;
 }