Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31323 )
Change subject: [WIP]mb/asus/p5ql-em: Add mainboard ......................................................................
Patch Set 1: Code-Review+1
(4 comments)
That is one ugly memory wiring...
https://review.coreboot.org/#/c/31323/1/src/mainboard/asus/p5ql-em/Kconfig File src/mainboard/asus/p5ql-em/Kconfig:
https://review.coreboot.org/#/c/31323/1/src/mainboard/asus/p5ql-em/Kconfig@4... PS1, Line 41: Name is "P5QL-EM" according to Asus (also check Kconfig.name)
https://review.coreboot.org/#/c/31323/1/src/mainboard/asus/p5ql-em/devicetre... File src/mainboard/asus/p5ql-em/devicetree.cb:
https://review.coreboot.org/#/c/31323/1/src/mainboard/asus/p5ql-em/devicetre... PS1, Line 73: device pci 1c.1 off end # PCIe 2 : device pci 1c.2 off end # PCIe 3 One of these should be the other PCIe x1 slot I guess
https://review.coreboot.org/#/c/31323/1/src/mainboard/asus/p5ql-em/devicetre... PS1, Line 163: device pci 1f.5 on # IDE According to ICH10 datasheet, this is the "SATA Controller #2" and should be disabled if operating the controller in AHCI mode.
Refer to "5.16 SATA Host Controller (D31:F2, F5)" on the datasheet.
https://review.coreboot.org/#/c/31323/1/src/mainboard/asus/p5ql-em/dsdt.asl File src/mainboard/asus/p5ql-em/dsdt.asl:
https://review.coreboot.org/#/c/31323/1/src/mainboard/asus/p5ql-em/dsdt.asl@... PS1, Line 33: Scope (_SB) { : Device (PCI0) Device (_SB.PCI0)