7 Feb
2021
7 Feb
'21
7:35 a.m.
Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47636 )
Change subject: nvramcui: Use libpayload's new `Makefile.payload` ......................................................................
Patch Set 3:
(1 comment)
File payloads/nvramcui/Makefile:
https://review.coreboot.org/c/coreboot/+/47636/comment/fff3eb36_f07cd11a PS3, Line 6: include ../libpayload/Makefile.payload
Missing an `all` target, apparently.
Yeah, which makes me wonder. Do we ever build-test building payloads as part of coreboot? Or are they only build-tested stand-alone?
--
To view, visit https://review.coreboot.org/c/coreboot/+/47636
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I34bf659c1a069ccc27ca613bbf86780d4da49259
Gerrit-Change-Number: 47636
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 07 Feb 2021 15:35:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment