Attention is currently required from: Paul Menzel, Aamir Bohra.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51086 )
Change subject: mb/intel/shadowmountain: Add Cr50 support
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51086/comment/6ac54395_4e42544c
PS5, Line 13: Verify TPM init is done in ve
In the logs attached to b/182244857, there seem to be a lot of TPM IRQ timeout messages. Are those fixed now?
File src/mainboard/intel/shadowmountain/variants/baseboard/early_gpio.c:
https://review.coreboot.org/c/coreboot/+/51086/comment/35d1b157_eb10c6a9
PS5, Line 27: UP_20K
Why is this required?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51086
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I33f7427d1675190f65acf14679be93546e6db69a
Gerrit-Change-Number: 51086
Gerrit-PatchSet: 5
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Comment-Date: Wed, 10 Mar 2021 17:48:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment