Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42799 )
Change subject: mb/google/zork: Add USB to baseboard devicetree
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42799/4/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/baseboard/devicetree_trembyle.cb:
https://review.coreboot.org/c/coreboot/+/42799/4/src/mainboard/google/zork/v...
PS4, Line 210: chip drivers/usb/acpi
Now that this is added to baseboard devicetree, USB port devices should be dropped from trembyle/ove […]
nvm. I see this is addressed in a follow up change: https://review.coreboot.org/c/coreboot/+/43437/1
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42799
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf8628d91e27a3afdc5fd67a53b44089c809da87
Gerrit-Change-Number: 42799
Gerrit-PatchSet: 4
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 14 Jul 2020 17:51:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment