[coreboot-gerrit] Change in coreboot[master]: lib/edid_fill_fb: Support multiple framebuffers

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39002 )

Change subject: lib/edid_fill_fb: Support multiple framebuffers
......................................................................

Patch Set 9:

(4 comments)

https://review.coreboot.org/c/coreboot/+/39002/7/src/lib/edid_fill_fb.c 
File src/lib/edid_fill_fb.c:

https://review.coreboot.org/c/coreboot/+/39002/7/src/lib/edid_fill_fb.c@34 
PS7, Line 34: edid_fb
> nit: Would probably be a good occasion to rename this field since it really has nothing to do with E […]

Done

https://review.coreboot.org/c/coreboot/+/39002/7/src/lib/edid_fill_fb.c@36 
PS7, Line 36: static struct fb_info list;
> This should just be a raw struct list_node.

Done

https://review.coreboot.org/c/coreboot/+/39002/7/src/lib/edid_fill_fb.c@56 
PS7, Line 56: struct fb_info *info,
> Why does this work so differently from fb_set_framebuffer_info()? Why can't you call fb_new_framebuf […]

Done

https://review.coreboot.org/c/coreboot/+/39002/7/src/lib/edid_fill_fb.c@109 
PS7, Line 109: set
> 'set' seems like the wrong verb here, especially in comparison to fb_set_orientation() (which change […]

Done