Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35443 )
Change subject: mb/supermicro/x11ssh: simplify variant mechanism
......................................................................
Patch Set 3: Code-Review-2
If you want to add variants it makes sense. I don't see any improvement, it even makes it worse. If you add 20 variants all of them have to be concatenated on the first line as done in #35427.
Selecting a base board is much cleaner design.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35443
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If64debe0dda6b32886f5288a6fe918b47c9dcd34
Gerrit-Change-Number: 35443
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Wed, 18 Sep 2019 07:08:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment