Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34506 )
Change subject: soc/intel/cannonlake: Disable ACPI PM timer to reduce S0ix power usage
......................................................................
Patch Set 7: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/34506/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34506/7//COMMIT_MSG@12
PS7, Line 12: devicetree set to 1.
Could you please add the note, that 10 mW are saved after the sentence?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34506
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I347c15c7b65fb4c19b9680f127980d4ddab8df51
Gerrit-Change-Number: 34506
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 25 Jul 2019 12:50:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment