build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26603 )
Change subject: src/northbridge: Remove whitespace before tab ......................................................................
Patch Set 9:
(14 comments)
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/agesa/family14/c... File src/northbridge/amd/agesa/family14/chip.h:
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/agesa/family14/c... PS9, Line 30: * { {0x00, 0x00}, {0x00, 0x00}, }, // socket 1 - Channel 0 & 1 (Unused) line over 80 characters
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdht/h3gtopo.h File src/northbridge/amd/amdht/h3gtopo.h:
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdht/h3gtopo.h@... PS9, Line 259: 0x00, 0x44, 0x00, 0x44, 0x00, 0x44, 0x00, 0x44, 0x00, 0x44, 0x00, 0x44, 0x10, 0xFF // Node6 line over 80 characters
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/amddefs.h File src/northbridge/amd/amdmct/amddefs.h:
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/amddefs.h... PS9, Line 77: #define AMD_DA_Cx (AMD_DA_C2 | AMD_DA_C3) please, no space before tabs
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct/mct_d... File src/northbridge/amd/amdmct/mct/mct_d.c:
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct/mct_d... PS9, Line 3756: * b) Reset the Begin Compensation bit (D3CMP->COMP_CONFIG[0]) in all the compensation engines line over 80 characters
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct/mctdq... File src/northbridge/amd/amdmct/mct/mctdqs_d.c:
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct/mctdq... PS9, Line 464: BanksPresent = 1; /* flag for at least one bank is present */ line over 80 characters
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct_ddr3/... File src/northbridge/amd/amdmct/mct_ddr3/mct_d.c:
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct_ddr3/... PS9, Line 7912: * b) Reset the Begin Compensation bit (D3CMP->COMP_CONFIG[0]) in all the compensation engines line over 80 characters
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct_ddr3/... File src/northbridge/amd/amdmct/mct_ddr3/mctecc_d.c:
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct_ddr3/... PS9, Line 118: OB_ChipKill = mctGet_NVbits(NV_ChipKill); /* ECC Chip-kill mode */ line over 80 characters
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct_ddr3/... PS9, Line 123: /* mct_AdjustScrub_D(pDCTstatA, &nvbits); */ /* Need not adjust */ line over 80 characters
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct_ddr3/... File src/northbridge/amd/amdmct/mct_ddr3/s3utils.c:
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/amdmct/mct_ddr3/... PS9, Line 699: // wrmsr_uint64_t(0x00000260 | (i + 8), data->msr0000026[i]); line over 80 characters
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/lx/northbridgein... File src/northbridge/amd/lx/northbridgeinit.c:
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/lx/northbridgein... PS9, Line 597: * SYSRC(7:0) = 00h ; writeback, can set to 08h to make writethrough line over 80 characters
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/lx/raminit.c File src/northbridge/amd/lx/raminit.c:
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/lx/raminit.c@422 PS9, Line 422: ((dimm_setting >> CF8F_LOWER_PRE2ACT_SHIFT) & 0x07)) code indent should use tabs where possible
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/lx/raminit.c@422 PS9, Line 422: ((dimm_setting >> CF8F_LOWER_PRE2ACT_SHIFT) & 0x07)) please, no space before tabs
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/lx/raminit.c@423 PS9, Line 423: << CF8F_LOWER_ACT2ACTREF_SHIFT; code indent should use tabs where possible
https://review.coreboot.org/#/c/26603/9/src/northbridge/amd/lx/raminit.c@423 PS9, Line 423: << CF8F_LOWER_ACT2ACTREF_SHIFT; please, no space before tabs