Hello Seunghwan Kim,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/37313
to review the following change.
Change subject: mb/google/kohaku: Adjust I2C clock frequency ......................................................................
mb/google/kohaku: Adjust I2C clock frequency
This change adjusts I2C speed settings to limit frequency to 400KHz.
The new setting values have been from other projects using same I2C components.
BUG=b:144885961 BRANCH=firmware-hatch-12672.B TEST=Verified I2C1 and I2C4 frequency not over 400KHz
Change-Id: I9614fb39b6e55cb2ce1b0879a9f5204e55002f8d Signed-off-by: Seunghwan Kim sh_.kim@samsung.com --- M src/mainboard/google/hatch/variants/kohaku/overridetree.cb 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/37313/1
diff --git a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb index 55ac071..d515ecc 100644 --- a/src/mainboard/google/hatch/variants/kohaku/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kohaku/overridetree.cb @@ -60,6 +60,8 @@ }, .i2c[1] = { .speed = I2C_SPEED_FAST, + .rise_time_ns = 60, + .fall_time_ns = 25, }, .i2c[2] = { .speed = I2C_SPEED_FAST, @@ -68,8 +70,8 @@ }, .i2c[4] = { .speed = I2C_SPEED_FAST, - .rise_time_ns = 100, - .fall_time_ns = 20, + .rise_time_ns = 104, + .fall_time_ns = 52, }, .gspi[0] = { .speed_mhz = 1,