Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37148 )
Change subject: mb/lenovo/x60: Add VBOOT support
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37148/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37148/4//COMMIT_MSG@9
PS4, Line 9: This also adds vboot support for the i945 platform in general.
Can you please split this into a separate commit, and describe there what has to be done on a platfo […]
But adding vboot support to i945 is just adding four lines! (╯°□°)╯︵ ┻━┻
/s
Bleh, not a big deal
https://review.coreboot.org/c/coreboot/+/37148/5//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37148/5//COMMIT_MSG@7
PS5, Line 7: VBOOT
lowercase? vboot
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37148
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia9666194e98b7d23b97eaff08e6177684e35eca7
Gerrit-Change-Number: 37148
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 09 Apr 2020 10:43:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment