build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28669 )
Change subject: mb/google/octopus: Close unused I2C bus 7 include SCL and SDA for Phaseer
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/#/c/28669/8/src/mainboard/google/octopus/variant...
File src/mainboard/google/octopus/variants/phaser/gpio.c:
https://review.coreboot.org/#/c/28669/8/src/mainboard/google/octopus/variant...
PS8, Line 64: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD),
line over 80 characters
https://review.coreboot.org/#/c/28669/8/src/mainboard/google/octopus/variant...
PS8, Line 107: }else
space required after that close brace '}'
--
To view, visit
https://review.coreboot.org/28669
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ad17761f2a053dc329bbec0a0a3284d47289666
Gerrit-Change-Number: 28669
Gerrit-PatchSet: 8
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jett Rink
jettrink@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Wed, 19 Sep 2018 16:25:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No