Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46326 )
Change subject: soc/amd/common: Add weak function definitions to get ioapic IDs
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46326/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46326/1//COMMIT_MSG@15
PS1, Line 15: MADT.
How can you tell if the values were taken from these functions and were […]
In my test image, i set the Kconfig used in the strong override to something other than the hardcoded values in the weak def. The defaults today are functionally the same, but allow the flexibility to specify a different ID for the ioapics for picasso and newer programs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46326
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib6778bf5141df580759e8158010a63d6af77e8ae
Gerrit-Change-Number: 46326
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 15 Oct 2020 18:49:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment