build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46555 )
Change subject: soc/intel/xeon_sp/{skx,cpx}: Add txt_get_chipset_dpr callback ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46555/6/src/soc/intel/xeon_sp/cpx/c... File src/soc/intel/xeon_sp/cpx/chip.c:
https://review.coreboot.org/c/coreboot/+/46555/6/src/soc/intel/xeon_sp/cpx/c... PS6, Line 569: struct device *dev = VTD_DEV(0); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/46555/6/src/soc/intel/xeon_sp/cpx/c... PS6, Line 569: struct device *dev = VTD_DEV(0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/46555/6/src/soc/intel/xeon_sp/skx/c... File src/soc/intel/xeon_sp/skx/chip.c:
https://review.coreboot.org/c/coreboot/+/46555/6/src/soc/intel/xeon_sp/skx/c... PS6, Line 585: struct device *dev = VTD_DEV(0); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/46555/6/src/soc/intel/xeon_sp/skx/c... PS6, Line 585: struct device *dev = VTD_DEV(0); please, no spaces at the start of a line