V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47523 )
Change subject: soc/intel/common: Add Kconfig to enable the CSE FW Update feature
......................................................................
Patch Set 6:
Patch Set 5:
Please address this build failure:
src/soc/intel/common/block/cse/cse_lite.c:413:34: note: each undeclared identifier is reported only once for each function it appears in
src/soc/intel/common/block/cse/cse_lite.c: In function 'cse_get_cbfs_rdev':
src/soc/intel/common/block/cse/cse_lite.c:426:35: error: 'CONFIG_SOC_INTEL_CSE_RW_CBFS_NAME' undeclared (first use in this function); did you mean 'CONFIG_SOC_INTEL_CSE_RW_UPDATE'?
if (cbfs_boot_locate(&file_desc, CONFIG_SOC_INTEL_CSE_RW_CBFS_NAME, NULL) < 0)
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47523
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12810031224f79aba8a4057725ae0ed5a9b36d7e
Gerrit-Change-Number: 47523
Gerrit-PatchSet: 6
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 16 Nov 2020 20:07:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment