Attention is currently required from: Felix Singer, Michał Żygowski, Paul Menzel, Michał Kopeć.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68448 )
Change subject: mb/msi/ms7d25: Add support for DDR5 variant ......................................................................
Patch Set 7: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68448/comment/368c0c35_f416d7f7 PS7, Line 10: difference is the board's DDR5 memory design. The only difference seems to be the PCB revision. From internet pictures, the DDR4 version is rev. 1.1 and the DDR5 version is rev. 2.1 (there could be other revisions): https://imgur.com/a/SaKdFs4
Do you think it'd be a good idea to set the mainboard revision (or mainboard version) field in SMBIOS accordingly?
File configs/config.dell_precision_t1650:
PS7: Oopsie?
File src/mainboard/msi/ms7d25/Kconfig:
https://review.coreboot.org/c/coreboot/+/68448/comment/9ede2728_bb1c4b5b PS7, Line 35: default "Default string" Hmmm
File src/mainboard/msi/ms7d25/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/68448/comment/c31bb7db_67e33d3b PS7, Line 15: .UserBd = BOARD_TYPE_DESKTOP_2DPC, No longer FIXME? Makes sense