Attention is currently required from: Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49176 ) Change subject: [WIP]device/Kconfig: Introduce separate graphics menu for Intel ...................................................................... Patch Set 2: (3 comments) File src/device/graphics/intel/Kconfig: https://review.coreboot.org/c/coreboot/+/49176/comment/25c08e8c_14012c94 PS2, Line 12: Selected by mainboards that do not have any graphics ports connected to the SoC. I would repurpose this option to allow mainboards to hide Intel graphics init options from Kconfig, e.g. supermicro/x11_lga1151_series. I know of several other mainboards where the iGPU is unusable. https://review.coreboot.org/c/coreboot/+/49176/comment/ce42a2a1_9c5ff1fb PS2, Line 21: config MAINBOARD_FORCE_NATIVE_INTEL_VGA_INIT Nothing needs to select this option, so I would not even add it in the first place. https://review.coreboot.org/c/coreboot/+/49176/comment/03445e3b_2b4fba1f PS2, Line 72: a nit: *FSP* GOP driver -- To view, visit https://review.coreboot.org/c/coreboot/+/49176 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I410fecfdb8a99ca520b2c05edd9ed2558d7e0a92 Gerrit-Change-Number: 49176 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-Attention: Patrick Rudolph <siro@das-labor.org> Gerrit-Comment-Date: Thu, 07 Jan 2021 18:19:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment