Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35239 )
Change subject: hatch: automate creating a new variant in coreboot ......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc... File util/mainboard/google/hatch/create_coreboot_variant.sh:
https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc... PS13, Line 16: if [[ ! -e /etc/cros_chroot_version ]]; then : echo "This script must be run inside the chroot" : exit 1 : fi
What's needed in the chroot? […]
Now that I look closer, nothing is needed for the chroot. I'm removing this check.
https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc... File util/mainboard/google/hatch/dptf.asl.tmpl:
https://review.coreboot.org/c/coreboot/+/35239/13/util/mainboard/google/hatc... PS13, Line 4: * Copyright __YEAR__ Google LLC
We're getting rid of all the copyright lines and just having the AUTHORS file instead. […]
This file actually shouldn't be part of the CL; I deleted it but it didn't get cherry-picked.
If we get rid of the copyrights, then __YEAR__ doesn't show up anywhere, and it becomes a simple copy. Is that what we want?