21 Oct
2020
21 Oct
'20
12:49 p.m.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45187 )
Change subject: cpu/x86/sipi: Add x86_64 support ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45187/1/src/cpu/x86/sipi_vector.S File src/cpu/x86/sipi_vector.S:
https://review.coreboot.org/c/coreboot/+/45187/1/src/cpu/x86/sipi_vector.S@2... PS1, Line 203: eax
nm that's . […]
It might be a good idea to have some sort of macro to use the correct pointer size for relocatable module parameters. Maybe the.section ".module_parameters" in C code is also an option?
--
To view, visit https://review.coreboot.org/c/coreboot/+/45187
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53eae082123d1a12cfa97ead1d87d84db4a334c0
Gerrit-Change-Number: 45187
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 21 Oct 2020 10:49:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment