Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87070?usp=email )
Change subject: mb/starlabs/starbook/adl_n: Tidy GPIO comments for deep GPIOs ......................................................................
mb/starlabs/starbook/adl_n: Tidy GPIO comments for deep GPIOs
This is a non-functional change, and only makes the GPIOs easier to read.
Change-Id: Ic69920c052707a44ecdd44c5879bbbf612cc03f8 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/87070 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c 1 file changed, 8 insertions(+), 17 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index 5f98b2b..705f6ee 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -17,29 +17,20 @@
/* Pad configuration in ramstage. */ const struct pad_config gpio_table[] = { - /* GPD0: Battery Low */ - PAD_CFG_NF(GPD0, NONE, DEEP, NF1), - /* GPD1: Charger Connected */ - PAD_CFG_NF(GPD1, NONE, DEEP, NF1), - /* GPD2: LAN Wake */ + /* General Purpose I/O Deep */ + PAD_CFG_NF(GPD0, NONE, DEEP, NF1), /* Battery Low */ + PAD_CFG_NF(GPD1, NONE, DEEP, NF1), /* Charger Connected */ + PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* Power Button */ + PAD_CFG_NF(GPD4, NONE, DEEP, NF1), /* Sleep S3 */ + PAD_CFG_NF(GPD5, NONE, DEEP, NF1), /* Sleep S4 */ + PAD_CFG_NF(GPD8, NONE, DEEP, NF1), /* Bluetooth Suspend */ + PAD_NC(GPD2, NONE), - /* GPD3: Power Button */ - PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), - /* GPD4: Sleep S3 */ - PAD_CFG_NF(GPD4, NONE, DEEP, NF1), - /* GPD5: Sleep S4 */ - PAD_CFG_NF(GPD5, NONE, DEEP, NF1), - /* GPD6: Sleep A */ PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ PAD_CFG_GPO(GPD7, 0, PWROK), - /* GPD8: Suspend Clock */ - PAD_CFG_NF(GPD8, NONE, DEEP, NF1), - /* GPD9: Wireless LAN Sleep */ PAD_NC(GPD9, NONE), - /* GPD10: Sleep S5 */ PAD_NC(GPD10, NONE), - /* GPD11: LAN PHY Enable */ PAD_NC(GPD11, NONE),
/* A0: ESPI IO 0 */