[coreboot-gerrit] Change in coreboot[master]: mb/intel/jasperlake_rvp: Replace static camera ACPI by driver

[Sugnan Prabhu S (Code Review)]

Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41758 )

Change subject: mb/intel/jasperlake_rvp: Replace static camera ACPI by driver
......................................................................

Patch Set 25:

(4 comments)

https://review.coreboot.org/c/coreboot/+/41758/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41758/5//COMMIT_MSG@7 
PS5, Line 7: mb/intel/jasperlake_rvp: camera SSDT changes for JSLRVP
> Please make it a statement by adding a verb in imperative mood.

Done

https://review.coreboot.org/c/coreboot/+/41758/5//COMMIT_MSG@8 
PS5, Line 8:
> Please elaborate.

Done

https://review.coreboot.org/c/coreboot/+/41758/11/src/drivers/intel/mipi_cam... 
File src/drivers/intel/mipi_camera/Kconfig:

https://review.coreboot.org/c/coreboot/+/41758/11/src/drivers/intel/mipi_cam... 
PS11, Line 4: default y
> this defaults to including the MIPI camera driver in every build, which is not what we want. […]

Done

https://review.coreboot.org/c/coreboot/+/41758/13/src/mainboard/intel/jasper... 
File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/41758/13/src/mainboard/intel/jasper... 
PS13, Line 397: device pci 05.0 on end # RP4
> I think what's mostly needed is to move the block of: […]

Done