Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45115 )
Change subject: soc/amd/picasso: Assign IOAPIC IDs using FSP ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45115/1/src/soc/amd/picasso/Kconfig File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/45115/1/src/soc/amd/picasso/Kconfig... PS1, Line 246: PICASSO_IOAPIC_IDS nit: I think it would be better to simply add two Kconfigs one for each IOAPIC_ID. That way we don't have to worry about ensuring that the same math is used anywhere the ID is referenced.