Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Name of user not set #1003801, Andrey Petrov, Patrick Rudolph, Julian Schroeder. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58869 )
Change subject: src/soc/amd/common/fsp: check FSP binary version. ......................................................................
Patch Set 1:
(3 comments)
File src/drivers/intel/fsp2_0/include/fsp/info_header.h:
https://review.coreboot.org/c/coreboot/+/58869/comment/a974167d_6254280b PS1, Line 34: #define FSP_INFO_HEADER_OFF 0x94
same offset. different header.
same offset, but the fsp_header isn't what's in the binary. see fsp_identify
https://review.coreboot.org/c/coreboot/+/58869/comment/8322e04e_a6eaf44f PS1, Line 35: fsp_info_header
this is an fsp_info_header. Quite different from a fsp_header.
ok, this isn't a redefinition. fsp_identify looks at the raw header and fills in the fsp_header struct fields. so i'd just use the fsp_header struct like it's done right now and don't use an additional struct for the raw fsp_info_header
File src/drivers/intel/fsp2_0/util.c:
https://review.coreboot.org/c/coreboot/+/58869/comment/ddc0c988_9cf54693 PS1, Line 80: struct fsp_info_header *info = (struct fsp_info_header *) (fsp_file + FSP_INFO_HEADER_OFF);
where would I get the fsp binary version from? I need the fsp_info_header to get the AMD image revis […]
hdr->fsp_revision should have all needed information