Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31909 )
Change subject: vboot: remove VBOOT_EC_SLOW_UPDATE Kconfig option
......................................................................
Patch Set 4: Code-Review+2
One thing you could do is add a CQ-DEPEND for the depthcharge CL here. That doesn't matter to coreboot.org, but once Patrick cherry-picks it into our tree it will block the CQ there.
Yeah, I did :/
CQ-DEPEND is in there, just hidden among the TEST= fields ;)
Sorry, I'm blind as usual. Looks all good.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31909
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4a83af2ba143577a064fc0d72c9bc318db56adc
Gerrit-Change-Number: 31909
Gerrit-PatchSet: 4
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 22 Mar 2019 05:45:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment