[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Move PRMRR options to CPU subfolder

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45345 )

Change subject: soc/intel/common/block: Move PRMRR options to CPU subfolder
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45345/2/src/soc/intel/common/block/... 
File src/soc/intel/common/block/cpu/Kconfig:

https://review.coreboot.org/c/coreboot/+/45345/2/src/soc/intel/common/block/... 
PS2, Line 106: 	prompt "PRMRR size"
> In that case, I vote for renaming get_prmrr_size() to make it clear that

it's not the effective size. Currently it's only called to set the UPD.
We should make sure nobody calls it and assumes that it will return the
effective size.

yep, maybe get_prmrr_setting?
> If FSP overrides PRMRR settings when C6DRAM is enabled, then we should hide this when C6DRAM is enabled.

no, it's doesn't override it, but it sets it to 1M, when EnableC6Dram=1 && PrmrrSize=0