[coreboot-gerrit] Change in coreboot[master]: mb/protectli/vault: Add FW2B and FW4B Braswell based boards support

[Michał Żygowski (Code Review)]

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32076 )

Change subject: mb/protectli/vault: Add FW2B and FW4B Braswell based boards support
......................................................................

Patch Set 18:

(2 comments)

https://review.coreboot.org/c/coreboot/+/32076/15/src/mainboard/protectli/va... 
File src/mainboard/protectli/vault_bsw/dsdt.asl:

https://review.coreboot.org/c/coreboot/+/32076/15/src/mainboard/protectli/va... 
PS15, Line 19: 	#include "onboard.h"
> This board seems not using Audio codec. […]

There is an audio codec, but verbs are not implemented yet, so is ACPI. It will be added as a future improvement.

https://review.coreboot.org/c/coreboot/+/32076/15/src/mainboard/protectli/va... 
File src/mainboard/protectli/vault_bsw/romstage.c:

https://review.coreboot.org/c/coreboot/+/32076/15/src/mainboard/protectli/va... 
PS15, Line 23: 	ite_enable_serial(SERIAL1_DEV, CONFIG_TTYS0_BASE);
> Am I right that ite_enable_serial is required also?

Yes, you are right.
> Am I right that ite_enable_serial is required also?

Already added, see latest patch.