HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36317 )
Change subject: src/mb: Get rid of wrong _ADR objects ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36317/6/src/mainboard/advansus/a785... File src/mainboard/advansus/a785e-i/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/36317/6/src/mainboard/advansus/a785... PS6, Line 1128: Name(_ADR, 0x00180000) /* Dev# = BSP Dev#, Func# = 0 */
By my understanding, only some legacy devices do need an _ADR. […]
My understanding here: ACPI specs version 6.3 - page #346, we have to use _ADR only for objects enumerated by enumerators other than Operating System-directed configuration and Power Management.
"_HID (Hardware ID) This object is used to supply OSPM with the device’s PNP ID or ACPI ID. 1 When describing a platform, use of any _HID objects is optional. However, a _HID object must be used to describe any device that will be enumerated by OSPM. OSPM only enumerates a device when no bus enumerator can detect the device ID. For example, devices on an ISA bus are enumerated by OSPM. Use the _ADR object to describe devices enumerated by bus enumerators other than OSPM."