mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31450 )
Change subject: lenovo/g505s: Add the discrete VGA support for AMD Lenovo G505S laptop
......................................................................
Patch Set 3:
Patch Set 3:
GPIO59 can be used to detect presence of DGPU.
Sorry but G505 and G505S are different laptops, here is a correct datasheet for G505S - LA-A091P motherboard - http://www.s-manuals.com/pdf/motherboard/compal/compal_la-a091p_r1.0_schemat... . I don't know how to find a correct GPIO there... but it is not necessary anymore: see comment above, it turned out we could set BottomIO to 0xD0 for all G505S
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31450
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98793fa3b1ad8ee7d0b7962a328f7d5c1b0c2f88
Gerrit-Change-Number: 31450
Gerrit-PatchSet: 3
Gerrit-Owner: mikeb mikeb
mikebdp2@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mikeb mikeb
mikebdp2@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 18 Feb 2019 15:22:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment