[coreboot-gerrit] Change in coreboot[master]: cbfs: Add metadata cache

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38423 )

Change subject: cbfs: Add metadata cache
......................................................................

Patch Set 16: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/38423/16/src/commonlib/bsd/cbfs_mca... 
File src/commonlib/bsd/cbfs_mcache.c:

https://review.coreboot.org/c/coreboot/+/38423/16/src/commonlib/bsd/cbfs_mca... 
PS16, Line 136: 		if (entry->magic != MCACHE_MAGIC_FILE) {
We check for corrupted mcache above. Any reason not to do similar checks here? Let it fail on subsequent lookup?

https://review.coreboot.org/c/coreboot/+/38423/16/src/include/cbfs.h 
File src/include/cbfs.h:

https://review.coreboot.org/c/coreboot/+/38423/16/src/include/cbfs.h@52 
PS16, Line 52: find
fill?