Attention is currently required from: Nico Huber, Angel Pons, Kyösti Mälkki, Felix Held. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52935 )
Change subject: nb/amd/agesa/family14/northbridge.c: Report missing resources ......................................................................
Patch Set 2:
(1 comment)
File src/northbridge/amd/agesa/family14/northbridge.c:
https://review.coreboot.org/c/coreboot/+/52935/comment/8f5fbbd4_60115d39 PS2, Line 382: resource_t
Same as above: mmio_resource() is a wrapper macro for fixed_mem_resource(), which takes arguments of […]
Then the fixed_mem_resource is not well designed. For example AMD Trinity has 48 physical address bits, there is no way to hold that much bits in unsigned long (32bit). Additionally CB:52922 is merged which uses resource_t. When basek and sizek is passed to mmio_resource or ram_resource it will be truncated to 32 bits. Yet another mess is the fixed_mem_resource, which casts basek and sizek to resource_t back. So what is the point anyway to use unsigned long arguments if they are cast back to resource_t??