Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46268 )
Change subject: soc/intel/common/block/acpi: Factor out common buttons.asl ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46268/1/src/mainboard/intel/icelake... File src/mainboard/intel/icelake_rvp/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/46268/1/src/mainboard/intel/icelake... PS1, Line 6: Device (PWRB)
I could see on Chrome OS, PWRB has listed as valid wake source from S3 and S0ix […]
This is not required. Please see the commit message here: https://review.coreboot.org/c/coreboot/+/27272/4//COMMIT_MSG