Attention is currently required from: Nico Huber, Martin Roth, Christian Walter.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49461 )
Change subject: payloads/external/seabios: Scan all PCI domains on Xeon-SP platforms
......................................................................
Patch Set 2:
(2 comments)
File payloads/external/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/49461/comment/3e1d020e_c50fa1f9
PS2, Line 117: domains
Does this scan all PCI domains or all PCI buses? Does it scan bus 255 or everything up to 255?
https://review.coreboot.org/c/coreboot/+/49461/comment/92e59daa_8c2f767f
PS2, Line 118: 255
Not sure, but maybe this should match `MAX_SOCKETS - 1`.
On my Xeon-SP there are devices on bus 0xff.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49461
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a99e1b9b6ea77fede6ed8239016bd92c5291c63
Gerrit-Change-Number: 49461
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Comment-Date: Thu, 06 May 2021 22:51:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
