Alex Thiessen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30991 )
Change subject: intel/apollolake: Add fixed resources for VTd to system resources ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Looks fine to me, though I have to admit I don't know much about resource handling here :D
https://review.coreboot.org/#/c/30991/2/src/soc/intel/apollolake/systemagent... File src/soc/intel/apollolake/systemagent.c:
https://review.coreboot.org/#/c/30991/2/src/soc/intel/apollolake/systemagent... PS2, Line 53: (MCHBAR32(GFXVTBAR) & VTBAR_MASK) / KiB
No, there is just this requirement of having this memory to be in KiB granularity. […]
I mean if the input is not KiB-granular, then you would lose the remainder. So the question is whether there is a _promise_ to have input KiB-granular. After checking the defines used here I see that's the case.
In C++ code I'd' request a few `static_assert`s here, but should be OK here.