Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38417 )
Change subject: vboot: Remove hard dependency on MISSING_BOARD_RESET
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38417/1/src/security/vboot/Kconfig
File src/security/vboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/38417/1/src/security/vboot/Kconfig@...
PS1, Line 31: depends on !MISSING_BOARD_RESET
I bow to your Kconfig mastery... I would have never figured that out. Thanks! […]
/me was left speechless by Nico's vast knowledge of Kconfig.
Would it be a good idea to replace this with a MAINBOARD_HAS_VBOOT symbol? I don't think selecting this when the board has no vboot support makes much sense.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38417
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia765f54b6e2e176e2d54478fb1e0839d8cab9849
Gerrit-Change-Number: 38417
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 16 Jan 2020 13:40:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment