Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55270 )
Change subject: soc/intel/alderlake: Add definition for virtual GPIOs
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120942):
https://review.coreboot.org/c/coreboot/+/55270/comment/b0001876_3e97f72c
PS1, Line 53: INTEL_GPP(GPP_S0, GPP_CPU_RSVD_1,GPP_CPU_RSVD_24), /* GPP_CPU_RSVD */
space required after that ',' (ctx:VxV)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55270
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d48553d14465df50e5aaaf27ab26c6a1b70d4cf
Gerrit-Change-Number: 55270
Gerrit-PatchSet: 1
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 07 Jun 2021 14:23:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment