Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34509 )
Change subject: mb/google/octopus: Override DDI1 DDC SDA/SCL for HDMI ......................................................................
Patch Set 8:
Patch Set 8:
Patch Set 8:
Ah, from the commit message, I wasn’t aware, that `./src/mainboard/google/octopus/variants/meep` exists.
Sorry, I confused *meep* and *dorp*.
$ git grep -i dorp src/vendorcode/intel/edk2/UDK2017/MdePkg/Include/IndustryStandard/Emmc.h: UINT8 VendorProprietaryHealthReport[32]; // Vendor proprietary health report [301:270] util/lint/spelling.txt:dorp||drop $ find . -iname "*dorp*"
The name Dorp needs to be added to the files in `src/mainboard/google/octopus/Kconfig*` in my opinion.
Paul, Dorp will share a firmware build with Meep, so it doesn't need a Kconfig file. I acknowledge that the terminology and handling of codenames is a bit confusing, and we'll try to make it clearer soon.