Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33102 )
Change subject: ec/apple: Add ACPI code for Apple MacBooks ......................................................................
Patch Set 17:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33102/17/src/ec/apple/acpi/ac.asl File src/ec/apple/acpi/ac.asl:
PS17: We use SPDX license headers now
https://review.coreboot.org/c/coreboot/+/33102/17/src/ec/apple/acpi/ac.asl@2... PS17, Line 22: , 1,
If this is LIDS, I'd say using different macro names isn't worth the hassle. […]
Bleh, not a big deal
https://review.coreboot.org/c/coreboot/+/33102/17/src/ec/apple/acpi/battery.... File src/ec/apple/acpi/battery.asl:
https://review.coreboot.org/c/coreboot/+/33102/17/src/ec/apple/acpi/battery.... PS17, Line 80: 0xFFFFFFFF, // 1: Design cap
These two aren't indented with tabs
Poke
https://review.coreboot.org/c/coreboot/+/33102/17/src/ec/apple/acpi/ec.asl File src/ec/apple/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/33102/17/src/ec/apple/acpi/ec.asl@4... PS17, Line 43: 0x62
yep, this should be 0x66. […]
Still not changed?