[coreboot-gerrit] Change in coreboot[master]: mb/google/zork/vilboz: Enable P sensor

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43665 )

Change subject: mb/google/zork/vilboz: Enable P sensor
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43665/1/src/mainboard/google/zork/v... 
File src/mainboard/google/zork/variants/vilboz/gpio.c:

https://review.coreboot.org/c/coreboot/+/43665/1/src/mainboard/google/zork/v... 
PS1, Line 13: PAD_SCI
> SCI is unnecessary

So, use PAD_INT?
> I think PULL_LOW is ok.

Why PULL_LOW? This is active low signal. Is this actively driven by the P-sensor or open-drain signal? Is there an external pull-up?