Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35287 )
Change subject: security/tpm: Use correct hash digest lengths
......................................................................
Patch Set 1: Code-Review+2
I guess we can take this as a quick fix, but this is far from everything that was wrong with that patch. Frans, please see my comments in CB:33252. (Or maybe it would be better just to revert it for now?)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35287
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9101f157d5a19836b200ecd99f060de552498d2
Gerrit-Change-Number: 35287
Gerrit-PatchSet: 1
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 06 Sep 2019 20:49:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment