Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33993 )
Change subject: mainboard/amd: Add padmelon board code ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33993/2/src/mainboard/amd/padmelon/... File src/mainboard/amd/padmelon/fan_init.c:
https://review.coreboot.org/c/coreboot/+/33993/2/src/mainboard/amd/padmelon/... PS2, Line 116: /* Open a LPC window to access the hardware monitor */ : reg = pci_read_config32(SOC_LPC_DEV, LPC_IO_PORT_DECODE_ENABLE); : t = reg | CONFIG_HWM_IO_WINDOW; : pci_write_config32(SOC_LPC_DEV, LPC_IO_PORT_DECODE_ENABLE, t); : No longer needed, found a way to do it using devicetree and PNP initialization.
https://review.coreboot.org/c/coreboot/+/33993/2/src/mainboard/amd/padmelon/... PS2, Line 131: /* restore register */ : pci_write_config32(SOC_LPC_DEV, LPC_IO_PORT_DECODE_ENABLE, reg); : } Same here, as it was complement from above.