Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45103 )
Change subject: drivers/ipmi: Add CONFIG_IPMI_KCS_TIMEOUT_MS for IPMI KCS timeout value
......................................................................
Patch Set 4:
(1 comment)
One more nit. Thank you for following up on the suggestions.
https://review.coreboot.org/c/coreboot/+/45103/4/src/drivers/ipmi/ipmi_kcs.c
File src/drivers/ipmi/ipmi_kcs.c:
https://review.coreboot.org/c/coreboot/+/45103/4/src/drivers/ipmi/ipmi_kcs.c...
PS4, Line 42: return 0;
If one branch using braces, all branches need to.
https://doc.coreboot.org/coding_style.html
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45103
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42ede1d9200bb5d0dbb455d2ff66e2816f10e86b
Gerrit-Change-Number: 45103
Gerrit-PatchSet: 4
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 05 Sep 2020 09:16:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment